Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Update dependencies #29052

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Sep 5, 2024

Closes N/A

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.5 MB 0 B 1.46 0%
initSize 161 MB 161 MB 0 B -1.68 0%
diffSize 84.6 MB 84.6 MB 0 B -1.81 0%
buildSize 7.48 MB 7.48 MB 0 B -1.03 0%
buildSbAddonsSize 1.62 MB 1.62 MB 0 B 1.75 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.31 MB 2.31 MB 0 B -1.73 0%
buildSbPreviewSize 352 kB 352 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 1.69 0%
buildPreviewSize 3 MB 3 MB 0 B -1.09 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 16.4s 26.7s 10.3s 2.17 🔺38.6%
generateTime 19.5s 23.5s 3.9s 0.66 17%
initTime 16.4s 18.3s 1.8s -0.03 10.3%
buildTime 16.6s 11.1s -5s -571ms -0.72 -50.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.7s 6.8s 1s -0.16 15.4%
devManagerResponsive 3.7s 4.3s 573ms -0.27 13.3%
devManagerHeaderVisible 643ms 763ms 120ms -0.11 15.7%
devManagerIndexVisible 677ms 799ms 122ms -0.14 15.3%
devStoryVisibleUncached 1.1s 1.4s 301ms 0.18 21.5%
devStoryVisible 677ms 800ms 123ms -0.13 15.4%
devAutodocsVisible 564ms 752ms 188ms 0.32 25%
devMDXVisible 595ms 725ms 130ms 0.27 17.9%
buildManagerHeaderVisible 619ms 775ms 156ms 0.33 20.1%
buildManagerIndexVisible 688ms 869ms 181ms 1.22 20.8%
buildStoryVisible 685ms 870ms 185ms 0.49 21.3%
buildAutodocsVisible 573ms 868ms 295ms 1.6 🔺34%
buildMDXVisible 533ms 792ms 259ms 2.1 🔺32.7%

Greptile Summary

This PR updates dependencies in two Storybook framework packages for Next.js, focusing on improving testing capabilities and compatibility.

  • Added '@storybook/test' as a peer dependency in code/frameworks/experimental-nextjs-vite/package.json
  • Updated 'styled-jsx' dependency from 5.1.1 to ^5.1.6 in code/frameworks/nextjs/package.json
  • These changes are minor but enhance testing support and ensure compatibility with recent versions of styled-jsx

Copy link

nx-cloud bot commented Sep 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit addcce3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review September 5, 2024 08:35
@valentinpalkovic valentinpalkovic merged commit 4472f10 into next Sep 5, 2024
60 of 70 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-dependency-req branch September 5, 2024 08:36
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant