-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SvelteKit: Introduce portable stories support #28918
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 16b4f11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
@@ -0,0 +1,5 @@ | |||
import { mockSveltekitStores } from './plugins/mock-sveltekit-stores' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding a brief comment explaining the purpose of this file and the storybookSveltekitPlugin
export const storybookSveltekitPlugin = () => { | ||
return [mockSveltekitStores()] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding type annotations for better clarity and to prevent potential issues
@@ -360,17 +360,40 @@ async function linkPackageStories( | |||
); | |||
} | |||
|
|||
const getVitestPluginInfo = (details: TemplateDetails) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding a type annotation for the return value of getVitestPluginInfo
705967e
to
d8ee6ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #28892
What I did
This PR introduces the ability to use SvelteKit in portable stories, therefore being able to use the Vitest addon plugin with it.
For that, you must configure the plugin that comes in the
vite
export of sveltekit:Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR introduces portable stories support for SvelteKit in Storybook, enabling the use of the Vitest addon plugin.
storybookSveltekitPlugin
incode/frameworks/sveltekit/src/vite.ts
for SvelteKit integrationpackage.json
to include new 'vite' export and bundler entriessandbox-templates.ts