Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Fix incorrect re-export in core-events #28573

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 12, 2024

What I did

There was an incorrect re-export in core-events

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff %
createTime 8s 22.8s 14.8s 🔺64.8%
generateTime 22.7s 23.7s 1s 4.3%
initTime 21.2s 26.4s 5.1s 🔺19.5%
createSize 0 B 0 B 0 B -
generateSize 76.5 MB 76.5 MB 0 B 0%
initSize 198 MB 198 MB 0 B 0%
diffSize 122 MB 122 MB 0 B 0%
buildTime 15.9s 12.2s -3s -716ms 🔰-30.3%
buildSize 7.59 MB 7.59 MB 0 B 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 0%
buildSbCommonSize 195 kB 195 kB 0 B 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 0%
buildSbPreviewSize 349 kB 349 kB 0 B 0%
buildStaticSize 0 B 0 B 0 B -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0%
testBuildTime 0ms 0ms 0ms -
testBuildSize 0 B 0 B 0 B -
testBuildSbAddonsSize 0 B 0 B 0 B -
testBuildSbCommonSize 0 B 0 B 0 B -
testBuildSbManagerSize 0 B 0 B 0 B -
testBuildSbPreviewSize 0 B 0 B 0 B -
testBuildStaticSize 0 B 0 B 0 B -
testBuildPrebuildSize 0 B 0 B 0 B -
testBuildPreviewSize 0 B 0 B 0 B -
devPreviewResponsive 9.5s 8.5s -998ms 🔰-11.7%
devManagerResponsive 6.1s 5.7s -442ms 🔰-7.7%
devManagerHeaderVisible 898ms 772ms -126ms 🔰-16.3%
devManagerIndexVisible 928ms 799ms -129ms 🔰-16.1%
devStoryVisibleUncached 1.3s 1.1s -160ms 🔰-13.4%
devStoryVisible 955ms 815ms -140ms 🔰-17.2%
devAutodocsVisible 784ms 827ms 43ms 🔺5.2%
devMDXVisible 812ms 728ms -84ms 🔰-11.5%
buildManagerHeaderVisible 845ms 885ms 40ms 4.5%
buildManagerIndexVisible 902ms 893ms -9ms -1%
buildStoryVisible 915ms 956ms 41ms 4.3%
buildAutodocsVisible 823ms 755ms -68ms 🔰-9%
buildMDXVisible 757ms 678ms -79ms 🔰-11.7%

@ndelangen ndelangen self-assigned this Jul 12, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Corrected re-export in /code/deprecated/core-events/shim.js from core-errors to core-events
  • Ensure functionality relying on core events is not broken

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jul 12, 2024
@ndelangen ndelangen requested review from shilman and yannbf July 12, 2024 14:33
Copy link

nx-cloud bot commented Jul 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f367015. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit bd0969f into next Jul 12, 2024
52 of 53 checks passed
@shilman shilman deleted the norbert/cpc-incorrect-export-core-events branch July 12, 2024 15:35
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2024
…rt-core-events

CPC: Fix incorrect re-export in `core-events`
(cherry picked from commit bd0969f)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants