Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Interactions: Use unique keys when rendering array nodes in panel #28423

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 2, 2024

Closes #

What I did

This PR fixes a specific issue where if your interactions panel uses an array of classes of the same name like so
image

Then it throws the following error:

chunk-B3YDJJJH.js:23 Warning: Encountered two children with the same key, `{"__class__":{"name":"File"}}`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
    at span
    at t_ (http://localhost:6006/sb-addons/interactions-9/manager-bundle.js:177:39208)
    at bt (http://localhost:6006/sb-addons/interactions-9/manager-bundle.js:177:37196)
    at span
    at ta (http://localhost:6006/sb-addons/interactions-9/manager-bundle.js:177:42581)
    at div
    at http://localhost:6006/sb-manager/chunk-B3YDJJJH.js:299:2900
    at button
    at http://localhost:6006/sb-manager/chunk-B3YDJJJH.js:299:2900
    at div
    at http://localhost:6006/sb-manager/chunk-B3YDJJJH.js:299:2900
    at div
    at http://localhost:6006/sb-manager/chunk-B3YDJJJH.js:299:2900
    at C_ (http://localhost:6006/sb-addons/interactions-9/manager-bundle.js:182:134)

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Jul 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d0ab771. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@yannbf yannbf merged commit 50ece49 into next Jul 3, 2024
54 of 55 checks passed
@yannbf yannbf deleted the yann/fix-interactions-key branch July 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants