Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix eslint configuration for string extends #27097

Merged
merged 1 commit into from
May 12, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented May 12, 2024

Closes N/A

What I did

Looks like ESlint config .extends can also be a string and our automigration fails in that case:

image

Thanks @ShaunEvening for the bug report! 🙌

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Install SB in a project with a string value for eslint extends

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented May 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7cc7d1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman force-pushed the shilman/fix-configure-estlint branch from 3bc2a51 to f7cc7d1 Compare May 12, 2024 08:24
@shilman shilman changed the title CLI: Fix eslint configuration for strings CLI: Fix eslint configuration for string extends May 12, 2024
@shilman
Copy link
Member Author

shilman commented May 12, 2024

Self-merging @yannbf @ShaunEvening

@shilman shilman merged commit 5557550 into next May 12, 2024
62 checks passed
@shilman shilman deleted the shilman/fix-configure-estlint branch May 12, 2024 09:03
@github-actions github-actions bot mentioned this pull request May 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant