-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Tools: Signature Type Error Handling #26774
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ffd17e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
…low-config-server-error-handling
…low-config-server-error-handling
…low-config-server-error-handling
…low-config-server-error-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our conversation, the potential issue is when having a type like:
type Props = {
myValue: SomeType['someProperty']
}
where internally it looks like this:
{
name: 'signature',
raw: 'SomeType['someProperty']'
}
1 - it could be an import from node_module which somehow is not available for docgen
2 - it could be an aliased/absolute import from a monorepo package which somehow is not available for docgen
we should really try to reproduce this bug so we can fix it as well
…error-handling Doc Tools: Signature Type Error Handling (cherry picked from commit 38afbe6)
Closes #
What I did
I added a custom server error for the doc tools
convertSig
function for the signature type handling.Previously, the error was generic and appeared like this:
The change outputs the error like this:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Manual testing should not be required, as the unit test verifies that the error message is output correctly.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>