Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix date picker control validation and assignment #26695

Merged
merged 8 commits into from
May 22, 2024

Conversation

leeovictor
Copy link
Contributor

@leeovictor leeovictor commented Mar 30, 2024

What I did

This PR fix two issues with the datepicker:

  1. An issue where it was not possible to clear the selected date using the native calendar, leading to 'invalid' message showing up
  2. An incorrectly formatted date value assign on the input when the date value is undefined

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access http://localhost:6006/?path=/story/addons-controls-basics--undefined story
  4. Insert a date on the date control
  5. Clear the date using the browser's native calendar 'Clear' button or backspace

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@leeovictor leeovictor marked this pull request as ready for review March 30, 2024 20:24
@leeovictor leeovictor marked this pull request as draft March 31, 2024 23:38
@leeovictor leeovictor marked this pull request as ready for review April 4, 2024 21:13
@valentinpalkovic valentinpalkovic self-assigned this Apr 8, 2024
Copy link

nx-cloud bot commented Apr 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 051b3ef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@leeovictor leeovictor changed the title fix date picker control validation and input value assign Controls: fix date picker control validation and input value assign Apr 9, 2024
@leeovictor
Copy link
Contributor Author

leeovictor commented May 21, 2024

hi @valentinpalkovic. do you have some news about this issue?

Copy link
Contributor

@valentinpalkovic valentinpalkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@valentinpalkovic valentinpalkovic merged commit 9226a94 into storybookjs:next May 22, 2024
49 of 51 checks passed
@github-actions github-actions bot mentioned this pull request May 22, 2024
25 tasks
@shilman shilman changed the title Controls: fix date picker control validation and input value assign Controls: Fix date picker control validation and assignment May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants