-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Fix react-dom/server
imports breaking stories and docs
#26557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
added
bug
addon: docs
ci:merged
Run the CI jobs that normally run when merged.
ci:daily
Run the CI jobs that normally run in the daily job.
builder-vite
labels
Mar 18, 2024
JReinhold
changed the title
add explicit react-dom/server alias for vite
Addon-docs: Fix Mar 18, 2024
react-dom/server
imports breaking stories and docs
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1e5a57c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
JReinhold
removed
the
ci:daily
Run the CI jobs that normally run in the daily job.
label
Mar 20, 2024
…orybookjs/storybook into jeppe/fix-react-dom-server-resolution
valentinpalkovic
approved these changes
Mar 21, 2024
JReinhold
added
ci:merged
Run the CI jobs that normally run when merged.
and removed
ci:merged
Run the CI jobs that normally run when merged.
labels
Mar 21, 2024
…orybookjs/storybook into jeppe/fix-react-dom-server-resolution
22 tasks
JReinhold
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Mar 24, 2024
storybook-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
Merged
9 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
…-resolution Addon-docs: Fix `react-dom/server` imports breaking stories and docs (cherry picked from commit d6eaf19)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addon: docs
bug
builder-vite
ci:daily
Run the CI jobs that normally run in the daily job.
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26532
To do
What I did
react-dom/server
, so Vite wouldn't resolve that toPATH/react-dom/server.js
(which just redirects toserver.node.js
but insteadPATH/react-dom/server.browser.js
.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Button.stories.ts
, addimport * as ReactDomServer from 'react-dom/server';
A. Try in a React-based and non-React sandbox
B. ... and try across Yarn, Yarn PnP and pnpm as well
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26557-sha-7290a2c2
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26557-sha-7290a2c2 sandbox
or in an existing project withnpx storybook@0.0.0-pr-26557-sha-7290a2c2 upgrade
.More information
0.0.0-pr-26557-sha-7290a2c2
jeppe/fix-react-dom-server-resolution
7290a2c2
1710774868
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26557