Addon-themes: Fix switcher initialization after first start

[valentinpalkovic]

Closes #

What I did

I have fixed an issue where the theme switcher doesn't appeared at the first start of Storybook. After reloading the page, the theme switcher was in place, though.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

1. Run a Next.js Typescript sandbox
2. Add @storybook/addon-themes addon and install @mui/material, @emotion/reset, @emotion/react, @emotion/styled
3. Adjust .storybook/preview.ts like so:

import type { Preview, ReactRenderer } from '@storybook/react';
import { withThemeFromJSXProvider } from '@storybook/addon-themes';
import { CssBaseline, ThemeProvider } from '@mui/material';
import { Roboto, Inika } from 'next/font/google';
import { createTheme } from '@mui/material/styles';

const roboto = Roboto({
  weight: ['300', '400', '500', '700'],
  subsets: ['latin'],
  display: 'swap',
});

const inika = Inika({
  weight: ['400', '700'],
  subsets: ['latin'],
  display: 'swap',
});

export const themeRoboto = createTheme({
  typography: {
    fontFamily: roboto.style.fontFamily,
  },
});

export const themeInika = createTheme({
  typography: {
    fontFamily: inika.style.fontFamily,
  },
  palette: {
    mode: 'dark',
  },
});


const preview: Preview = {
  parameters: {
    controls: {
      matchers: {
        color: /(background|color)$/i,
        date: /Date$/i,
      },
    },
  },

  decorators: [
      withThemeFromJSXProvider<ReactRenderer>({
        themes: {
          light: themeRoboto,
          dark: themeInika,
        },
        defaultTheme: 'light',
        Provider: ThemeProvider,
        GlobalStyles: CssBaseline,
      }),
    ],
};

export default preview;

4. Open Storybook and a Story and make sure the theme switcher at the top is initialized and visible

Note: Currently, switching the theme doesn't have any effect on Docs pages (I'll investigate whether this is a newly introduced bug or whether it was never working there).
-->

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4e0b97f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many --target=prep --all --parallel=8 --max-parallel=3 -- --reset --optimized

---

Sent with 💌 from NxCloud.