Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix logic to add ^ packages in upgrade #26049

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 15, 2024

Closes #25811

What I did

I changed the logic that determins to add or not add a ^ to the version range to upgrade to.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This is super hard to test, I could use some help finding ways to test this proper.

I think it will require publishing to verdaccio multiple times, withg multiple versions and possible multiple dist tags. Not something we really have scripts for to do.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26049-sha-b8adcad0. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26049-sha-b8adcad0 sandbox or in an existing project with npx storybook@0.0.0-pr-26049-sha-b8adcad0 upgrade.

More information
Published version 0.0.0-pr-26049-sha-b8adcad0
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch norbert/fix-caret-in-upgrade
Commit b8adcad0
Datetime Tue Feb 20 10:55:41 UTC 2024 (1708426541)
Workflow run 7972334583

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26049

@ndelangen ndelangen changed the title fix logic to add caret to upgrade CLI: Fix logic to add caret to upgrade Feb 15, 2024
@ndelangen ndelangen self-assigned this Feb 15, 2024
@ndelangen ndelangen changed the title CLI: Fix logic to add caret to upgrade CLI: Fix logic to add^ packages in upgrade Feb 15, 2024
@ndelangen ndelangen changed the title CLI: Fix logic to add^ packages in upgrade CLI: Fix logic to add ^ packages in upgrade Feb 15, 2024
@ndelangen ndelangen marked this pull request as ready for review February 15, 2024 22:27
@ndelangen ndelangen merged commit 22f7db6 into next Feb 22, 2024
59 checks passed
@ndelangen ndelangen deleted the norbert/fix-caret-in-upgrade branch February 22, 2024 13:08
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: incorrect Stroybook version number in package.json
3 participants