CLI: Fix add command for non monorepo deps #25791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
changed the title
yannbf
reviewed
Jan 30, 2024
yannbf
approved these changes
Jan 30, 2024
| @@ -55,7 +55,10 @@ export abstract class JsPackageManager { | |||
| basePath?: string | |||
| ): Promise<PackageJson | null>; | |||
|
|
|||
| public abstract getPackageVersion(packageName: string, basePath?: string): Promise<string | null>; | |||
| async getPackageVersion(packageName: string, basePath = this.cwd): Promise<string | null> { | |||
There was a problem hiding this comment.
@yannbf This function was indeed just used by the add command. I looked it up wrongly previously.
shilman
added
patch:yes
yannbf
approved these changes
Jan 31, 2024
valentinpalkovic
deleted the
valentin/fix-add-command-for-non-monorepo-deps
branch
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25790
What I did
Running
npx storybook@next add <package>on non-mono-repo addons sometimes failed because the wrong version number was taken. Now, the check to determine whether a package is a mono repo package or not was adjusted to take theversions.tsfile into account.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --start-from auto --template react-vite/default-ts/path-to-storybook/code/lib/cli/bin/index.js add @storybook/addon-webpack5-compiler-babelDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25791-sha-731531eb. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-25791-sha-731531eb sandboxor in an existing project withnpx storybook@0.0.0-pr-25791-sha-731531eb upgrade.More information
0.0.0-pr-25791-sha-731531ebvalentin/fix-add-command-for-non-monorepo-deps731531eb1706634771)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25791