Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Upgrade boxen library #25713

Merged
merged 3 commits into from
Feb 1, 2024
Merged

CLI: Upgrade boxen library #25713

merged 3 commits into from
Feb 1, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 23, 2024

Closes #

What I did

Attempt to fix a very annoying issue e.g.
image

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25713-sha-6d618302. Try it out in a new sandbox by running npx storybook@0.0.0-pr-25713-sha-6d618302 sandbox or in an existing project with npx storybook@0.0.0-pr-25713-sha-6d618302 upgrade.

More information
Published version 0.0.0-pr-25713-sha-6d618302
Triggered by @yannbf
Repository storybookjs/storybook
Branch yann/update-boxen
Commit 6d618302
Datetime Thu Feb 1 10:22:51 UTC 2024 (1706782971)
Workflow run 7739715454

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25713

Copy link

socket-security bot commented Jan 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/boxen@7.1.1 None +15 416 kB sindresorhus
npm/camelcase@7.0.1 None 0 11.7 kB sindresorhus
npm/cli-boxes@3.0.0 None 0 6.62 kB sindresorhus
npm/widest-line@4.0.1 None +2 22.8 kB sindresorhus

🚮 Removed packages: npm/boxen@5.1.2, npm/ws@8.15.0

View full report↗︎

@ndelangen
Copy link
Member

Please check if there are not multiple places where we use this package, and if so, we should consider upgrading everywhere.

@ndelangen ndelangen marked this pull request as ready for review February 1, 2024 10:06
@ndelangen
Copy link
Member

I upgraded boxen in more places.

  • I tested the sandbox command
  • I tested the storybook dev command
  • I tested resizing the terminal's width

It all looked exactly how I was expecting it to look, the terminal wrapping looked improved.

@ndelangen ndelangen merged commit 5e5019d into next Feb 1, 2024
63 of 70 checks passed
@ndelangen ndelangen deleted the yann/update-boxen branch February 1, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants