-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigFile: Fix export specifiers #25590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
Bugfix & documentation PR that need to be picked to main branch
csf
labels
Jan 13, 2024
tmeasday
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I'm not sure if that fixes the problem I ran into or not, but I'll assume it does!
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
This was referenced Jan 16, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ort-specifier ConfigFile: Fix export specifiers (cherry picked from commit cb97367)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jan 17, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:normal
csf
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Fixed another corner case for config file:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Use this pattern in
preview.x
ormain.x
in a sandbox.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>