-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Gracefully handle error when parsing preview.js file #24858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
bug
patch:yes
Bugfix & documentation PR that need to be picked to main branch
telemetry
labels
Nov 15, 2023
yannbf
requested review from
shilman,
ndelangen and
kasperpeulen
as code owners
November 15, 2023 16:56
valentinpalkovic
approved these changes
Nov 16, 2023
storybook-bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
This was referenced Nov 16, 2023
Closed
storybook-bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Core: Gracefully handle error when parsing preview.js file (cherry picked from commit c4eac36)
JReinhold
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:normal
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
telemetry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23604
What I did
When parsing Storybook metadata, there's a chance the preview file breaks in the CSF AST parsing step.
That's because users might have unconventional code in their preview.js file which is not parseable:
This PR handles the error in case it happens, and also improves the error message when it comes to AST parsing errors.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>