UI: Upgrade manager to react 18 #24514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the first step. Lots of stuff borked ``` yarn up react @types/react @types/react-dom @testing-library/react ``` Immediate issues with mismatched react-dom that wasn't listed explicitly in package.json before, so ``` yarn add react-dom ```
ndelangen
requested review from
cdedreuille,
tmeasday,
valentinpalkovic,
kasperpeulen and
yannbf
as code owners
valentinpalkovic
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Code-wise LGTM! Do you want me to test something in particular @ndelangen?
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @types/react@16.14.50, @types/react-dom@16.9.21 |
JReinhold
reviewed
Oct 19, 2023
JReinhold
approved these changes
Oct 19, 2023
The state merging of useAddonState needed a fix because the merger function wasn't called with the correct data, due to react18 using async rendering, making this.state be the old state.
…to norbert/react18
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #21673
Closes #20378
Closes #22217
What i did:
Upgrade react and some testing deps then fix the fallout.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]