Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Run postinstall in shell for windows #24389

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Themes: Run postinstall in shell for windows #24389

merged 4 commits into from
Oct 18, 2023

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Oct 5, 2023

What I did

  • Run postinstall script in shell for windows
  • Break up command string into command and args

Checklist for Contributors

Testing

Manual testing

  1. Use pnpm
  2. Create a vue-cli sandbox
  3. pnpm add -D tailwindcss postcss autoprefixer
  4. pnpm dlx tailwindcss init -p
  5. Add tailwind global css file with the following code
    @tailwind base;
    @tailwind components;
    @tailwind utilities;
  6. pnpm dlx storybook@latest add @storybook/addon-themes@<CANARY_VERSION>
  7. CLI should not error out

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24389-sha-88c59837. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-24389-sha-88c59837
Triggered by @cdedreuille
Repository storybookjs/storybook
Branch postinstall/themes
Commit 88c59837
Datetime Thu Oct 5 14:12:46 UTC 2023 (1696515166)
Workflow run 6420253530

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24389

@ShaunEvening ShaunEvening added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 5, 2023
@ShaunEvening ShaunEvening self-assigned this Oct 5, 2023
@yannbf yannbf merged commit 6b930ec into next Oct 18, 2023
51 of 53 checks passed
@yannbf yannbf deleted the postinstall/themes branch October 18, 2023 05:43
storybook-bot pushed a commit that referenced this pull request Oct 18, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
storybook-bot pushed a commit that referenced this pull request Oct 18, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
storybook-bot pushed a commit that referenced this pull request Oct 18, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
storybook-bot pushed a commit that referenced this pull request Oct 18, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
storybook-bot pushed a commit that referenced this pull request Oct 19, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
storybook-bot pushed a commit that referenced this pull request Oct 19, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
storybook-bot pushed a commit that referenced this pull request Oct 19, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
storybook-bot pushed a commit that referenced this pull request Oct 19, 2023
Themes: Run postinstall in shell for windows
(cherry picked from commit 6b930ec)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants