-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes: Run postinstall in shell for windows #24389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaunEvening
added
bug
patch:yes
Bugfix & documentation PR that need to be picked to main branch
labels
Oct 5, 2023
yannbf
reviewed
Oct 5, 2023
storybook-bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
This was referenced Oct 18, 2023
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Themes: Run postinstall in shell for windows (cherry picked from commit 6b930ec)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Oct 19, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:normal
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Checklist for Contributors
Testing
Manual testing
pnpm add -D tailwindcss postcss autoprefixer
pnpm dlx tailwindcss init -p
pnpm dlx storybook@latest add @storybook/addon-themes@<CANARY_VERSION>
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-24389-sha-88c59837
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-24389-sha-88c59837
postinstall/themes
88c59837
1696515166
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24389