Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextJS: Change babel plugins from proposal-... to transform-... #24290

Merged
merged 6 commits into from
Oct 3, 2023
Merged

NextJS: Change babel plugins from proposal-... to transform-... #24290

merged 6 commits into from
Oct 3, 2023

Conversation

roottool
Copy link
Contributor

@roottool roottool commented Sep 24, 2023

Closes #24070

What I did

I convert babel plugins from @babel/plugin-proposal-... to @babel/plugin-transform-....

There are two areas that I intentionally did not change.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  • compile
  • typecheck
  • Create the sandbox from a template
    • nextjs/12-js
    • nextjs/default-js
    • nextjs/default-ts
  • build
    • nextjs/12-js
    • nextjs/default-js
    • nextjs/default-ts

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@socket-security
Copy link

socket-security bot commented Sep 24, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @babel/plugin-proposal-export-namespace-from@7.18.9, @babel/plugin-proposal-object-rest-spread@7.20.7

@ndelangen ndelangen changed the title Change babel plugins from @babel/plugin-proposal-... to @babel/plugin-transform-... NextJS: Change babel plugins from proposal-... to transform-... Oct 2, 2023
@ndelangen ndelangen added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Oct 2, 2023
@ndelangen ndelangen merged commit fa57f76 into storybookjs:next Oct 3, 2023
65 of 87 checks passed
@roottool roottool deleted the feature/24070/convert-babel-plugins branch October 3, 2023 09:16
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
20 tasks
@yannbf yannbf mentioned this pull request Oct 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. configuration babel / webpack maintenance User-facing maintenance tasks nextjs react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Warnings on deprecated modules
3 participants