Telemetry: Filter addon options to protect sensitive info #24000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
ci:normal
patch:yes
storybook-bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
This was referenced Aug 30, 2023
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…metry Telemetry: Filter addon options to protect sensitive info (cherry picked from commit 7b4f37f)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
Don't send addon options in telemetry since it could contain sensitve info like PII or keys
What I did
Only send essentials options, which don't contain either of these things and we care about.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Run a sandbox with
STORYBOOK_TELEMETRY_DEBUG=1or viewproject.json🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>