TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 #23574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
kasperpeulen,
JReinhold,
valentinpalkovic and
yannbf
as code owners
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
ndelangen
added
patch:yes
|
I'm digging a bit deeper, and this is what I found: Considering every minor release of typescript is effectively a breaking change... How do I move forward with this? |
|
I think we should roll back to type-fest 2.19 indeed. |
This was referenced Jul 24, 2023
Closed
33 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 (cherry picked from commit 77b040c)
kasperpeulen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23554
What I did
I looked up which version of
type-feststarted depending ontypescript5.0, and downgraded to the last available version that doesn't.How to test
@j-m It'd be great if you could help us verify this change will solve your issue.
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]