-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Improve Button layout and props #23356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdedreuille
changed the title
Cleanup - Improved Button layout and props
Cleanup: Improved Button layout and props
Jul 10, 2023
cdedreuille
changed the title
Cleanup: Improved Button layout and props
UI: Improve Button layout and props
Jul 10, 2023
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
move @storybook/experimental-ui/src into ui/components/src/new remove @storybook/experimental-ui
…s/storybook into charles/update-button
ndelangen
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The Button component had a lot of variants that were not used and confusing. Some versions were also missing compared to the design. This PR is an attempt to add the new props for the
<Button />
component while still maintaining backward compatibility with versions that uses the old props.<Button />
componentHow to test
yarn task --task sandbox --start-from auto --template react-vite/default-ts
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]