Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Suppress dev-server info table when --quiet is true #23133

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

syabro
Copy link
Contributor

@syabro syabro commented Jun 19, 2023

Closes #23127

What I did

Disabled verbose table on dev start when --quiet provided

How to test

  1. Add --quiet to devCommand in scripts/tasks/dev.ts
  2. run yarn start

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@syabro
Copy link
Contributor Author

syabro commented Jun 19, 2023

Have no idea how to add a label :(

@shilman shilman added maintenance User-facing maintenance tasks cli labels Jun 19, 2023
@ndelangen
Copy link
Member

@syabro I think this is an improvement.

I'd love to take this further and make the --quiet flag mean:

when the --quiet flag is set to true, storybook will not output anything to the command-line except for errors.

Would you be interested in making that happen? In a follow up PR.

@ndelangen ndelangen changed the title Disable dev server info table with --quiet #23127 CLI: Suppress dev-server info table when --quiet is true Jun 21, 2023
@syabro
Copy link
Contributor Author

syabro commented Jun 21, 2023

@syabro I think this is an improvement.

Sorry? Don't get it :(

Would you be interested in making that happen? In a follow up PR.

Not sure, but could try.

@ndelangen
Copy link
Member

@syabro I think this is an improvement.

Sorry? Don't get it :(

Sorry if I was unclear.
It's a compliment, I like this PR, it's taking the code into the right direction, and it's a direction I'd love to see continue.

I'll merge this PR as-is; if you would like to improve further, please open another PR ❤️

Congrats on your first PR to storybook!

@ndelangen ndelangen merged commit ed10589 into storybookjs:next Jun 21, 2023
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add ability to disable dev starting info
4 participants