-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Allow .mjs
extension for CSF stories
#23125
Merged
ndelangen
merged 15 commits into
storybookjs:next
from
idesigncode:my-first-storybook-contribution
Jun 21, 2023
Merged
Core: Allow .mjs
extension for CSF stories
#23125
ndelangen
merged 15 commits into
storybookjs:next
from
idesigncode:my-first-storybook-contribution
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idesigncode
changed the title
Fix: Allow ESM .mjs files for CSF stories
Allow ESM .mjs files for CSF stories
Jun 19, 2023
Thanks for this @idesigncode ! I think you missed this one though
|
ndelangen
approved these changes
Jun 21, 2023
ndelangen
changed the title
Allow ESM .mjs files for CSF stories
Core: Allow Jun 21, 2023
.mjs
extension for CSF stories
12 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23078
What I did
lib/core-common
normalizeStoriesEntry
default files glob patternlib/core-server
csfIndexer
to allow ESM.mjs
type story files.StoryIndexGenerator
&stories-json
testslib/cli
configureMain
extensionsui
blocksOnlyStories
glob patternsHow to test
yarn start
yarn test
lib/core-common/src/utils/__tests__/normalize-stories.test.ts
lib/core-server/src/utils/StoryIndexGenerator.test.ts
lib/core-server/src/utils/stories-json.test.ts
lib/cli/src/automigrate/fixes/bare-mdx-stories-glob.test.ts
lib/cli/src/generators/configure.test.ts
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]