Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix core-common to use node-fetch #23077

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 14, 2023

Closes #

What I did

I don't know how this has gone unnoticed.

core-common is a node package, but it seems to use fetch without any place where it's imported; meaning it's from a global. Node 16 does not ship with fetch build-in.

How to test

Ran into this here:
https://github.com/chromaui/addon-visual-tests

It's using auto-refs, that's likely how this code-path gets executed?

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-assigned this Jun 14, 2023
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core labels Jun 14, 2023
@ndelangen ndelangen merged commit a4c2383 into next Jun 14, 2023
@ndelangen ndelangen deleted the norbert/node-fetch-core-common branch June 14, 2023 20:16
@ndelangen ndelangen changed the title Bug: Make core-common use node-fetch Core: Make core-common use node-fetch Jun 14, 2023
@shilman shilman changed the title Core: Make core-common use node-fetch Core: Fix core-common to use node-fetch Jun 15, 2023
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
9 tasks
shilman pushed a commit that referenced this pull request Jun 17, 2023
…mmon

Bug: Make core-common use node-fetch
(cherry picked from commit a4c2383)
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants