Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index: Don't prepend titlePrefix to a docs entry that references a CSF file's title #18634

Merged
merged 2 commits into from
Jul 9, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 6, 2022

Telescoping on #18595

When using <Meta of={csfFile}> you want the csfFile's title, not a prefixed version.

@tmeasday tmeasday requested a review from shilman July 6, 2022 02:35
@nx-cloud
Copy link

nx-cloud bot commented Jul 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 392603b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday force-pushed the tom/sb-451-preview-no-longer-allow-story-entries-to branch from 68ea524 to d68956b Compare July 6, 2022 09:12
@ndelangen ndelangen marked this pull request as draft July 6, 2022 22:54
@tmeasday tmeasday force-pushed the tom/sb-451-preview-no-longer-allow-story-entries-to branch from 36dae59 to e19e16c Compare July 7, 2022 02:25
@tmeasday tmeasday force-pushed the no-title-prefix-for-meta-of branch from 0a04719 to abd9404 Compare July 7, 2022 02:26
@tmeasday tmeasday marked this pull request as ready for review July 7, 2022 03:20
Base automatically changed from tom/sb-451-preview-no-longer-allow-story-entries-to to future/base July 8, 2022 15:05
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Don't append the titlePrefix to a docs entry that references a CSF file's title. Index: Don't prepend titlePrefix to a docs entry that references a CSF file's title Jul 9, 2022
@shilman shilman merged commit 3dcb4f0 into future/base Jul 9, 2022
@shilman shilman deleted the no-title-prefix-for-meta-of branch July 9, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants