Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future/doc blocks #18429

Closed
wants to merge 37 commits into from
Closed

Future/doc blocks #18429

wants to merge 37 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 7, 2022

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

shilman and others added 30 commits May 4, 2022 09:08
@shilman @okonet
Storybook doc blocks package init
eb99f7e
@okonet
chore: Move EmptyBlock and Source to /lib/blocks
3d58f37
@okonet
docs(Source): Add types and improve stories
4787b4f
@okonet
fix: Export EmptyBlock and Source from /blocks
e0ac0b8
@okonet
fixup! fix: Export EmptyBlock and Source from /blocks
cf2a728
@okonet
refactor: Move all block to @storybook/blocks
af70592
@okonet
refactor: Add and cleanup dependencies
314819d
@okonet
refactor: Move controls to @storybook/blocks
99db303
@okonet
fix: Remove dependency to @storybook/blocks and replace with the dire…
363aabe 
…ct path
@okonet
chore: Update yarn.lock
c8e49eb
@okonet
fixup! refactor: Add and cleanup dependencies
beee06c
@okonet
fix: Remove cross-dependency on @storybook/blocks
3c314d1
@okonet
docs(blocks): Update readme
81b0369
@okonet
fix(blocks): Fix imports and add missing export to components
a11bcef
@okonet
fix(blocks): Add typings.d.ts
672166b
@okonet
chore: Fix typo in moduleResolution
8bb901c
@okonet
fix: Update import to blocks
b7f2ced
@okonet
fix(addon-docs): Update imports
34ce9c5
@okonet
fix(addon-controls): Fix imports for the addon-controls
3308c21
@okonet
chore: Update yarn.lock
419707b
@okonet
chore: Bump dependencies for blocks package
1539583
@ndelangen
fix the build
d20a3c7
@okonet
fix(blocks): Import type separately
ff2648f
@okonet
Fix type imports / exports
442ca4f
@shilman
Doc blocks: Separate storybook package to break circular dependency
6777232
@shilman
Blocks: Move components to subdirectory
f804b47
@shilman
Blocks: Convert blocks stories to CSF3 autotitle
c5d3f07
@shilman
Blocks: Move doc blocks to @storybook/blocks
59c4b16
@okonet
Merge pull request #18410 from storybookjs/future/doc-blocks-example
d92be12 
Blocks: Move blocks out of addon-docs into blocks
@shilman
Examples: Setup chromatic in doc-blocks
e1c7741
@nx-cloud
Copy link

nx-cloud bot commented Jun 7, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 553fc49. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies","other"]

Generated by 🚫 dangerJS against e0a4a1d

Base automatically changed from future/docs2-core to future/base June 21, 2022 10:51
@shilman shilman mentioned this pull request Jun 28, 2022
Merged
5 tasks
@tmeasday
Copy link
Member

@shilman did this get merged already in a different PR?

@shilman
Copy link
Member Author

shilman commented Jul 14, 2022

Yes. It was superseded by #18587

Closing!

@shilman shilman closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shilman @tmeasday @okonet @ndelangen