-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue/Vue3: Fix decorators in StoryStoreV7 #18375
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fc2edfa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Awesome @yannbf |
7d2a0c1
to
6d411ab
Compare
6d411ab
to
6845817
Compare
@yannbf great job! any idea what's going on with the chromatic snapshots? |
Yup! Chromatic spotted a bug for us, however not related to this PR:
That's why the snapshots are different. The new snapshot is actually the correct style that the story should have looked like in the first place! |
Codecov Report
@@ Coverage Diff @@
## next #18375 +/- ##
=======================================
Coverage 32.05% 32.05%
=======================================
Files 975 975
Lines 19211 19211
Branches 4031 4031
=======================================
Hits 6158 6158
Misses 12489 12489
Partials 564 564
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Vue/Vue3: Fix decorators in StoryStoreV7
Issue: N/A
What I did
Both Storybook for Vue and Vue3 had issues when running in StoryStoreV7 mode. Reason being that Storybook needed a
applyDecorator
function as a preset, but it wasn't exported from the presets. This PR fixes that by exporting the function correctly.For Vue2 projects the entire Storybook would break with
For Vue3 projects, Storybook worked but decorators would not render the components.
With this PR, both Vue and Vue3 will render components correctly.
I also upgraded the vue example projects to use storyStoreV7
Thanks @prashantpalikhe @tmeasday for the investigation help! <3
How to test
If your answer is yes to any of these, please make sure to include it in your PR.