Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-highlight: Convert to simplified addon style #17991

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 18, 2022

Issue: N/A

What I did

Converted the highlight to the new simplified preview/manager.js style per #17755

@winkerVSbecks Not sure if I'm doing something wrong:

How to test

yarn bootstrap --core
cd examples/html-kitchen-sink
yarn storybook
# use a11y addon

@shilman shilman added maintenance User-facing maintenance tasks addon: highlight labels Apr 18, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 18, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5dadc45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title Addon-highlight: Remove preset Addon-highlight: Convert to simplified addon style Apr 18, 2022
@winkerVSbecks
Copy link
Contributor

@shilman some of the examples don't use addon-essentials. I've updated them to use the addon-highlight. The test should pass now.

@shilman
Copy link
Member Author

shilman commented Apr 18, 2022

@winkerVSbecks that makes sense. doesn't that make this a breaking change then, since users of addon-a11y will need to install addon-highlight? if so, i think we need to wait until 7.0 to merge this.

@winkerVSbecks
Copy link
Contributor

Yea that makes sense. My assumption was that including it in essentials would avoid that issue. I'll merge you PR for now and then hold off on mine until 7.0

@winkerVSbecks winkerVSbecks merged commit a53c1fc into addon-highlight Apr 18, 2022
@winkerVSbecks winkerVSbecks deleted the addon-highlight-remove-preset branch April 18, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: highlight maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants