Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add dev/build commands #17898

Merged
merged 38 commits into from
Apr 26, 2022
Merged

CLI: Add dev/build commands #17898

merged 38 commits into from
Apr 26, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 6, 2022

Issue: N/A

What I did

  • Add commands sb dev/sb build
  • Remove deprecated flags
  • Convert the examples
  • Add sb dev/build to default CLI templates

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented Apr 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 69eec05. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title CLI: Add start/build commands CLI: Add dev/build commands Apr 8, 2022
"generate-custom-elements-manifest": "yarn custom-elements-manifest analyze --litelement --dev --exclude \"./**/*.stories.ts\" --exclude \"./storybook-static\"",
"storybook": "start-storybook -p 9006 --no-manager-cache"
"sb": "node ../../lib/cli/bin/index.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: consolidate on sb build/dev NOT yarn sb build/dev

@shilman shilman marked this pull request as ready for review April 26, 2022 08:09
@shilman shilman merged commit e6ccfd1 into future/base Apr 26, 2022
@shilman shilman deleted the future/sb-start-build branch April 26, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant