Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] enable config overrides #80

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

gabrielcsapo
Copy link
Collaborator

fixes #38

Summary

Allows config overrides via existing config object such as

"storybook": {
  "config": { 
    "script": {
      "src": "./assets/foo.js"
    }
  }
}

Other

I migrated the tests to Jest as the manual string assertion makes it hard to add tests.

@gabrielcsapo
Copy link
Collaborator Author

I am going to add husky and lint-staged in the next PR. Lots of good cleanups we can do after almost 3 years of the initial implementation... time flies.

@dbendaou dbendaou added the enhancement New feature or request label Aug 10, 2021
@gabrielcsapo gabrielcsapo merged commit b399835 into storybookjs:master Aug 12, 2021
@gabrielcsapo gabrielcsapo deleted the fixes-#38 branch August 12, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add custom head tags?
2 participants