fix(tool-nuxt): add composables and fix types #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
commented
Jul 29, 2024
There was a problem hiding this comment.
this part is already moved to nuxt-base
There was a problem hiding this comment.
copied & modified from tool-plugins/nextjs-starter
Comment on lines
+3
to
+9
| const appBridge = useAppBridge(); | ||
| const nuxtApp = useNuxtApp(); | ||
| nuxtApp.provide('appBridge', { | ||
| completed, | ||
| appBridgeAuth, | ||
| oauth, | ||
| }); | ||
| nuxtApp.provide('appBridge', appBridge); | ||
| </script> | ||
|
|
||
| <template> | ||
| <slot v-if="!config.appBridge.enabled || completed" /> | ||
| <slot v-if="!config.appBridge.enabled || appBridge.completed.value" /> |
There was a problem hiding this comment.
As there's a possibility to add more to the return of useAppBridge, I provide the whole appBridge instead of spreading and passing everything.
Because of that change, I had to put appBridge.completed.value in the v-if.
(Not appBridge.completed, because appBridge.completed is still a ref object there. Let me know if you don't understand why it's still not a ref object there)
eunjae-lee
merged commit 4bf0a19
into
SHAPE-6288-starter-for-tool-plugin
1 check passed
BibiSebi
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR
useAutoHeight()anduseStoryContext()composables