fix(space-nuxt-base): catch FetchError correctly #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
requested review from
a team,
demetriusfeijoo,
BibiSebi and
Dawntraoz
and removed request for
a team
Dawntraoz
previously approved these changes
Jun 3, 2024
|
While testing today the ìnstanceOf seemed to be working, I need to retry tomorrow. |
@BibiSebi did you test it with |
|
@eunjae-lee I just retested it on "production" with console log and it worked. |
|
I've added a button that throws an error, and I don't know how you tested it. Anyway this is not super urgent, so I'll keep this open until you come back and give it a test together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
err instance of FetchErrorworks on development mode, but not on the production. So we're changing the way to check the error.Note
I was working on another ticket where we wanted to prevent user from being redirected to /error.vue when a specific server error happens. I couldn't solve it yet. However, during the debugging, I've realized FetchError didn't work on the production, so I opened this PR independently.