fix: resolve local references for external refs

Author: pytlesk4

src/__tests__/resolver.spec.ts

@@ -173,6 +173,70 @@ describe('resolver', () => {
       expect(resolved.result).toEqual(source);
     });
 
+    test('resolvePointers option should force to true for remote authorities', async () => {
+      const data = {
+        oas: {
+          swagger: '2.0',
+          definitions: {
+            user: {
+              address: {
+                $ref: '#/definitions/address',
+              },
+            },
+            address: {
+              title: 'Address',
+            },
+          },
+        },
+      };
+
+      const fileReader: Types.IReader = {
+        async read(): Promise<any> {
+          return data.oas;
+        },
+      };
+
+      const source = {
+        definitions: {
+          foo: {
+            $ref: '#/definitions/bar',
+          },
+          bar: {
+            title: 'bar',
+          },
+          someOASFile: {
+            $ref: './main.oas2.yml#/definitions/user',
+          },
+        },
+      };
+
+      const resolver = new Resolver({
+        readers: {
+          file: fileReader,
+        },
+      });
+
+      const result = await resolver.resolve(source, {
+        resolvePointers: false,
+      });
+
+      expect(result.result).toEqual({
+        definitions: {
+          foo: {
+            $ref: '#/definitions/bar',
+          },
+          bar: {
+            title: 'bar',
+          },
+          someOASFile: {
+            address: {
+              title: 'Address',
+            },
+          },
+        },
+      });
+    });
+
     test('should support chained jsonPointers + partial resolution', async () => {
       const source = {
         hello: {

src/runner.ts

@@ -60,7 +60,14 @@ export class ResolveRunner implements Types.IResolveRunner {
     this.readers = opts.readers || {};
     this.getRef = opts.getRef || defaultGetRef;
     this.transformRef = opts.transformRef;
-    this.resolvePointers = typeof opts.resolvePointers !== 'undefined' ? opts.resolvePointers : true;
+    // Need to resolve pointers if depth is greater than zero because that means the autority has changed, and the
+    // local refs need to be resolved.
+    if (this.depth) {
+      this.resolvePointers = true;
+    } else {
+      this.resolvePointers = typeof opts.resolvePointers !== 'undefined' ? opts.resolvePointers : true;
+    }
+
     this.resolveAuthorities = typeof opts.resolveAuthorities !== 'undefined' ? opts.resolveAuthorities : true;
     this.parseAuthorityResult = opts.parseAuthorityResult;
     this.ctx = opts.ctx;