fix: handle JSON pointer parsing errors - local refs (#147)

* fix: handle JSON pointer parsing errors - local refs

* style: lint.fix

Author: P0lip

src/__tests__/resolver.spec.ts

@@ -1425,7 +1425,7 @@ describe('resolver', () => {
       expect(result.errors.length).toEqual(1);
     });
 
-    test('should track syntactically invalid JSON pointers', async () => {
+    test('should track syntactically invalid JSON pointers used by remote refs', async () => {
       const source = {
         foo: 'bar',
         inner: {
@@ -1457,6 +1457,38 @@ describe('resolver', () => {
       ]);
     });
 
+    test('should track syntactically invalid JSON pointers used by local refs', async () => {
+      const source = {
+        foo: 'bar',
+        inner: {
+          $ref: '#.',
+        },
+      };
+
+      const resolver = new Resolver({
+        resolvers: {
+          file: {
+            async resolve() {
+              return {};
+            },
+          },
+        },
+      });
+
+      const result = await resolver.resolve(source);
+
+      expect(result.errors).toStrictEqual([
+        {
+          code: 'PARSE_POINTER',
+          message: "'#.' JSON pointer is invalid",
+          path: [],
+          uriStack: [],
+          pointerStack: [],
+          uri: expect.any(Object),
+        },
+      ]);
+    });
+
     test('should replace what it can even if some inner remote refs fail', async () => {
       const source = {
         inner: {

src/crawler.ts

@@ -1,4 +1,5 @@
 import { pointerToPath } from '@stoplight/json';
+import { Optional } from '@stoplight/types';
 import { DepGraph } from 'dependency-graph';
 import { get } from 'lodash';
 
@@ -20,7 +21,7 @@ export class ResolveCrawler implements Types.ICrawler {
 
   private _runner: Types.IResolveRunner;
 
-  constructor(runner: Types.IResolveRunner, jsonPointer?: string) {
+  constructor(runner: Types.IResolveRunner, jsonPointer: Optional<string>, private _resolved: Types.IResolveResult) {
     this.jsonPointer = jsonPointer;
     this._runner = runner;
   }
@@ -95,7 +96,21 @@ export class ResolveCrawler implements Types.ICrawler {
     if (Utils.uriIsJSONPointer(ref)) {
       if (this._runner.dereferenceInline) {
         const targetPointer = Utils.uriToJSONPointer(ref);
-        const targetPath = pointerToPath(targetPointer);
+        let targetPath;
+        try {
+          targetPath = pointerToPath(targetPointer);
+        } catch {
+          this._resolved.errors.push({
+            code: 'PARSE_POINTER',
+            message: `'${ref}' JSON pointer is invalid`,
+            uri: this._runner.baseUri,
+            uriStack: this._runner.uriStack,
+            pointerStack: [],
+            path: [],
+          });
+
+          return;
+        }
 
         /**
          * Protects against circular references back to something higher up in the tree

src/runner.ts

@@ -151,7 +151,7 @@ export class ResolveRunner implements Types.IResolveRunner {
     }
 
     // create our crawler instance
-    const crawler = new ResolveCrawler(this, jsonPointer);
+    const crawler = new ResolveCrawler(this, jsonPointer, resolved);
 
     // crawl to build up the uriResolvers and pointerGraph
     crawler.computeGraph(resolved.result, targetPath, jsonPointer || '');

src/types.ts

@@ -247,6 +247,7 @@ export interface IResolveRunner {
   dereferenceRemote: boolean;
   uriCache: ICache;
   depth: number;
+  uriStack: string[];
   baseUri: uri.URI;
 
   graph: DepGraph<IGraphNodeData>;