fix: handle JSON pointer parsing errors (#140)

Author: P0lip

src/__tests__/resolver.spec.ts

@@ -1360,6 +1360,38 @@ describe('resolver', () => {
       expect(result.errors.length).toEqual(1);
     });
 
+    test('should track syntactically invalid JSON pointers', async () => {
+      const source = {
+        foo: 'bar',
+        inner: {
+          $ref: 'https://foo.com/oas#invalid',
+        },
+      };
+
+      const resolver = new Resolver({
+        resolvers: {
+          https: {
+            async resolve() {
+              return {};
+            },
+          },
+        },
+      });
+
+      const result = await resolver.resolve(source);
+
+      expect(result.errors).toStrictEqual([
+        {
+          code: 'PARSE_POINTER',
+          message: "'#invalid' JSON pointer is invalid",
+          path: [],
+          uriStack: [],
+          pointerStack: [],
+          uri: expect.any(Object),
+        },
+      ]);
+    });
+
     test('should replace what it can even if some inner remote refs fail', async () => {
       const source = {
         inner: {

src/runner.ts

@@ -119,7 +119,21 @@ export class ResolveRunner implements Types.IResolveRunner {
     let targetPath: any;
     const jsonPointer = opts && opts.jsonPointer && opts.jsonPointer.trim();
     if (jsonPointer && jsonPointer !== '#' && jsonPointer !== '#/') {
-      targetPath = pointerToPath(jsonPointer);
+      try {
+        targetPath = pointerToPath(jsonPointer);
+      } catch {
+        resolved.errors.push({
+          code: 'PARSE_POINTER',
+          message: `'${jsonPointer}' JSON pointer is invalid`,
+          uri: this.baseUri,
+          uriStack: this.uriStack,
+          pointerStack: [],
+          path: [],
+        });
+
+        return resolved;
+      }
+
       resolved.result = get(resolved.result, targetPath);
     }
 

src/types.ts

@@ -184,7 +184,9 @@ export type ResolverErrorCode =
   | 'RESOLVE_URI'
   | 'PARSE_URI'
   | 'RESOLVE_POINTER'
+  | 'PARSE_POINTER'
   | 'TRANSFORM_DEREFERENCED';
+
 export interface IResolveError {
   code: ResolverErrorCode;
   message: string;