Correct expected position information in error messages #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjaylward
changed the title
|
Merge after stleary/JSON-java#352 is committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see stleary/JSON-java#352 or
stleary/JSON-java#350 for the changes from PR 352 plus android support changes.
The current tests on Master are verifying error messages from the tokeners, but using incorrect position information. This PR corrects the position information in the tests, as well as adds new tests to verify position information.
This PR will fail on the current master branch of JSON-Java until one of the above mentioned PR for JSON-Java are merged.