feat: add watch and unwatch commands
#1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniGod
force-pushed
the
add-commands-watch-unwatch
branch
from
d485615 to
63f58f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried following the style of the rest of the repo. All tests are passing. E2E too.
The one thing I'm least confident about is the event emitter I used to let the "client" know about changed keys to track changed keys. If you have a better solution for it, let me know.
A side-effect of using an event emitter like I did, is that a lot of tests emit a warning about the number of listeners since the same
contextis used in many tests, but theRedisinstances are not alwaysdisconnected, so the clients pile up.Solves #1334