Skip to content

test: remove flaky designation for test-net-connect-options-port #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

test: remove flaky designation for test-net-connect-options-port #22

merged 1 commit into from
Feb 20, 2020

Conversation

@sthagen
Copy link
Owner

@sthagen sthagen commented Feb 20, 2020

Closes: nodejs#23207

PR-URL: nodejs#31841
Fixes: nodejs#23207
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: David Carlier devnexen@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
test: remove flaky designation for test-net-connect-options-port
cdac185 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@sthagen sthagen merged commit e67240c into sthagen:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky: test-net-connect-options-port

2 participants

@sthagen @Trott