on duplicate header: return values as list

Fixes peritus#4

Author: peritus

src/HttpLibrary/__init__.py

@@ -353,9 +353,12 @@ def response_should_not_have_header(self, header_name):
     def get_response_header(self, header_name):
         """
         Get the response header with the name `header_name`
+
+        If there are two headers with the same key, the return value of this
+        keyword is a list containing both values.
         """
         self.response_should_have_header(header_name)
-        return self.response.headers[header_name]
+        return self.response.headers.getall(header_name)
 
     def response_header_should_equal(self, header_name, expected):
         """

src/HttpLibrary/livetest.py

@@ -76,7 +76,11 @@ def _do_httplib_request(self, req):
         res = webtest.TestResponse()
         res.status = '%s %s' % (webresp.status, webresp.reason)
         res.body = webresp.read()
-        res.headerlist = webresp.getheaders()
+        response_headers = []
+        for headername in dict(webresp.getheaders()).keys():
+            for headervalue in webresp.msg.getheaders(headername):
+                response_headers.append((headername, headervalue))
+        res.headerlist = response_headers
         res.errors = ''
         return res
 

tests/http/mockserver.py

@@ -68,6 +68,12 @@ def do_GET(self):
             self.end_headers()
             self.wfile.write("***%s***" % self.headers['Host'])
             self.finish()
+        elif self.path == '/duplicate_header':
+            self.send_response(200, 'OK')
+            self.send_header('Duplicate', 'Yes')
+            self.send_header('Duplicate', 'Si!')
+            self.end_headers()
+            self.finish()
         else:
             self.send_error(500)
 

tests/http/simple.txt

@@ -246,6 +246,11 @@ HEAD request with User Agent Header
     HEAD                           /
     Response Header Should Equal   x-request-user-agent   MYBROWSER
 
+Test Duplicate Headers
+    GET     /duplicate_header
 
-
+    ${x}=               Get Response Header   Duplicate
+    Length Should Be    ${x}        2
+    Should Be Equal     ${x[0]}     Yes
+    Should Be Equal     ${x[1]}     Si!