fixes found with mcp server testing

Core architectural fix where wrapper clients now properly delegate to underlying
raw clients instead of reimplementing functionality. Adds missing search() method
to AlfrescoSearchClient wrapper. Includes post-processed models and updated examples
for wrapper integration. Resolves import naming consistency (SQL vs Sql).
All manual work preserved (docs, events).

Author: stevereiner

python_alfresco_api/__init__.py

@@ -16,7 +16,7 @@
 
 # Individual clients
 from .clients.auth_client import AlfrescoAuthClient
-from .clients.core_client import AlfrescoCoreClient
+from .clients.core_client import AlfrescoCoreClient  
 from .clients.discovery_client import AlfrescoDiscoveryClient
 from .clients.search_client import AlfrescoSearchClient
 from .clients.workflow_client import AlfrescoWorkflowClient
@@ -31,13 +31,13 @@
     # Factory & utilities
     "ClientFactory",
     "AuthUtil",
-
+    
     # Individual clients
     "AlfrescoAuthClient",
-    "AlfrescoCoreClient",
+    "AlfrescoCoreClient", 
     "AlfrescoDiscoveryClient",
     "AlfrescoSearchClient",
-    "AlfrescoWorkflowClient",
+    "AlfrescoWorkflowClient", 
     "AlfrescoModelClient",
     "AlfrescoSearchSQLClient"
 ]

python_alfresco_api/auth_util.py

@@ -5,17 +5,18 @@
 Handles ticket-based authentication with automatic renewal.
 """
 
+import asyncio
+from typing import Optional, Dict, Any
 from datetime import datetime, timedelta
-from typing import Dict
 
 class AuthUtil:
     """
     Shared authentication utility for Alfresco APIs.
-
+    
     Handles ticket-based authentication with automatic renewal.
     Can be shared across multiple API clients.
     """
-
+    
     def __init__(
         self,
         base_url: str,
@@ -26,7 +27,7 @@ def __init__(
     ):
         """
         Initialize authentication utility.
-
+        
         Args:
             base_url: Base URL of Alfresco instance
             username: Alfresco username
@@ -39,64 +40,64 @@ def __init__(
         self.password = password
         self.verify_ssl = verify_ssl
         self.timeout = timeout
-
+        
         self.ticket = None
         self.ticket_expires = None
         self._authenticated = False
-
+    
     async def authenticate(self) -> bool:
         """
         Authenticate with Alfresco and get ticket.
-
+        
         Returns:
             True if authentication successful, False otherwise
         """
         try:
             # Import here to avoid circular imports
             from .clients.auth_client import AlfrescoAuthClient
             from .models.alfresco_auth_models import TicketBody
-
+            
             auth_client = AlfrescoAuthClient(self.base_url, None, self.verify_ssl, self.timeout)
-
+            
             ticket_body = TicketBody(userId=self.username, password=self.password)
             ticket_response = await auth_client.create_ticket(ticket_body)
-
+            
             if ticket_response and hasattr(ticket_response, 'entry'):
                 self.ticket = ticket_response.entry.id
                 # Tickets typically expire after 1 hour
                 self.ticket_expires = datetime.now() + timedelta(hours=1)
                 self._authenticated = True
                 return True
-
+                
         except Exception as e:
             print(f"Authentication failed: {e}")
             self._authenticated = False
-
+        
         return False
-
+    
     def is_authenticated(self) -> bool:
         """Check if currently authenticated with valid ticket"""
         if not self._authenticated or not self.ticket:
             return False
-
+        
         if self.ticket_expires and datetime.now() >= self.ticket_expires:
             self._authenticated = False
             return False
-
+        
         return True
-
+    
     def get_auth_headers(self) -> Dict[str, str]:
         """Get authentication headers for API requests"""
         if not self.is_authenticated():
             return {}
-
+        
         return {
             "X-Alfresco-Ticket": self.ticket
         }
-
+    
     async def ensure_authenticated(self) -> bool:
         """Ensure we have valid authentication, refresh if needed"""
         if self.is_authenticated():
             return True
-
+        
         return await self.authenticate()

python_alfresco_api/client_factory.py

@@ -18,10 +18,10 @@
 class ClientFactory:
     """
     Factory for creating Alfresco API clients.
-
+    
     Supports both individual client creation and shared authentication.
     """
-
+    
     def __init__(
         self,
         base_url: str,
@@ -32,51 +32,51 @@ def __init__(
     ):
         """
         Initialize the client factory.
-
+        
         Args:
             base_url: Base URL of Alfresco instance
             username: Optional username for authentication
-            password: Optional password for authentication
+            password: Optional password for authentication  
             verify_ssl: Whether to verify SSL certificates
             timeout: Request timeout in seconds
         """
         self.base_url = base_url
         self.verify_ssl = verify_ssl
         self.timeout = timeout
-
+        
         # Initialize auth utility if credentials provided
         self.auth = None
         if username and password:
             self.auth = AuthUtil(base_url, username, password, verify_ssl, timeout)
-
+    
     def create_auth_client(self) -> AlfrescoAuthClient:
         """Create Authentication API client"""
         return AlfrescoAuthClient(self.base_url, self.auth, self.verify_ssl, self.timeout)
-
+    
     def create_core_client(self) -> AlfrescoCoreClient:
         """Create Core API client"""
         return AlfrescoCoreClient(self.base_url, self.auth, self.verify_ssl, self.timeout)
-
+    
     def create_discovery_client(self) -> AlfrescoDiscoveryClient:
         """Create Discovery API client"""
         return AlfrescoDiscoveryClient(self.base_url, self.auth, self.verify_ssl, self.timeout)
-
+    
     def create_search_client(self) -> AlfrescoSearchClient:
         """Create Search API client"""
         return AlfrescoSearchClient(self.base_url, self.auth, self.verify_ssl, self.timeout)
-
+    
     def create_workflow_client(self) -> AlfrescoWorkflowClient:
         """Create Workflow API client"""
         return AlfrescoWorkflowClient(self.base_url, self.auth, self.verify_ssl, self.timeout)
-
+    
     def create_model_client(self) -> AlfrescoModelClient:
         """Create Model API client"""
         return AlfrescoModelClient(self.base_url, self.auth, self.verify_ssl, self.timeout)
-
+    
     def create_search_sql_client(self) -> AlfrescoSearchSQLClient:
         """Create Search SQL API client"""
         return AlfrescoSearchSQLClient(self.base_url, self.auth, self.verify_ssl, self.timeout)
-
+    
     def create_all_clients(self) -> Dict[str, Any]:
         """Create all available clients"""
         return {

python_alfresco_api/clients/auth_client.py

@@ -23,14 +23,14 @@
 class AlfrescoAuthClient:
     """
     Individual client for Alfresco AUTH API.
-
+    
     Features:
     - Uses generated HTTP client internally
     - Automatic authentication with AuthUtil
     - Pydantic model integration
     - Both sync and async methods
     """
-
+    
     def __init__(
         self,
         base_url: str,
@@ -40,7 +40,7 @@ def __init__(
     ):
         """
         Initialize auth client.
-
+        
         Args:
             base_url: Base URL of Alfresco instance
             auth_util: Optional AuthUtil instance for authentication
@@ -51,11 +51,11 @@ def __init__(
         self.auth_util = auth_util
         self.verify_ssl = verify_ssl
         self.timeout = timeout
-
+        
         # Initialize the generated client
         self._init_generated_client()
-
-    def _init_generated_client(self) -> None:
+    
+    def _init_generated_client(self):
         """Initialize the generated HTTP client"""
         try:
             from client import Client
@@ -65,56 +65,16 @@ def _init_generated_client(self) -> None:
             print(f"⚠️  Generated client not available for auth: {e}")
             self.client = None
             self._client_available = False
-
+    
     def is_available(self) -> bool:
         """Check if the generated client is available"""
         return self._client_available
-
-    async def _ensure_auth(self) -> None:
+    
+    async def _ensure_auth(self):
         """Ensure authentication before API calls"""
         if self.auth_util:
             await self.auth_util.ensure_authenticated()
-
-    async def create_ticket(self, ticket_body) -> Any:
-        """Create authentication ticket"""
-        if not self._client_available:
-            # Simplified mock response for when client isn't available
-            print("⚠️  Auth client not fully initialized - using basic auth")
-            return type('MockTicketResponse', (), {
-                'entry': type('Entry', (), {'id': 'mock-ticket-basic-auth'})()
-            })()
-            
-        try:
-            # Try to use the actual generated client
-            import httpx
-            
-            # Build request directly
-            url = f"{self.base_url}/alfresco/api/-default-/public/authentication/versions/1/tickets"
-            
-            # Convert ticket_body to dict
-            if hasattr(ticket_body, 'model_dump'):
-                data = ticket_body.model_dump()
-            elif hasattr(ticket_body, 'dict'):
-                data = ticket_body.dict()
-            else:
-                data = ticket_body
-                
-            async with httpx.AsyncClient(verify=self.verify_ssl, timeout=self.timeout) as client:
-                response = await client.post(url, json=data)
-                
-                if response.status_code == 201:
-                    result = response.json()
-                    return type('TicketResponse', (), {
-                        'entry': type('Entry', (), {'id': result.get('entry', {}).get('id', 'no-ticket')})()
-                    })()
-                else:
-                    print(f"⚠️  Auth request failed with status {response.status_code}")
-                    return None
-                    
-        except Exception as e:
-            print(f"⚠️  Auth fallback: {e}")
-            return None
-
+    
     def get_client_info(self) -> Dict[str, Any]:
         """Get information about this client"""
         return {

python_alfresco_api/clients/core_client.py

@@ -23,14 +23,14 @@
 class AlfrescoCoreClient:
     """
     Individual client for Alfresco CORE API.
-
+    
     Features:
     - Uses generated HTTP client internally
     - Automatic authentication with AuthUtil
     - Pydantic model integration
     - Both sync and async methods
     """
-
+    
     def __init__(
         self,
         base_url: str,
@@ -40,7 +40,7 @@ def __init__(
     ):
         """
         Initialize core client.
-
+        
         Args:
             base_url: Base URL of Alfresco instance
             auth_util: Optional AuthUtil instance for authentication
@@ -51,11 +51,11 @@ def __init__(
         self.auth_util = auth_util
         self.verify_ssl = verify_ssl
         self.timeout = timeout
-
+        
         # Initialize the generated client
         self._init_generated_client()
-
-    def _init_generated_client(self) -> None:
+    
+    def _init_generated_client(self):
         """Initialize the generated HTTP client"""
         try:
             from client import Client
@@ -65,16 +65,16 @@ def _init_generated_client(self) -> None:
             print(f"⚠️  Generated client not available for core: {e}")
             self.client = None
             self._client_available = False
-
+    
     def is_available(self) -> bool:
         """Check if the generated client is available"""
         return self._client_available
-
-    async def _ensure_auth(self) -> None:
+    
+    async def _ensure_auth(self):
         """Ensure authentication before API calls"""
         if self.auth_util:
             await self.auth_util.ensure_authenticated()
-
+    
     def get_client_info(self) -> Dict[str, Any]:
         """Get information about this client"""
         return {