Add back keyboard shortcut features (#9) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muachilin
changed the title
|
My guess is that it's going to take a bit more work than just restoring the file from the old version of the project. The current GUI library that is used is JavaFX and just looking at the imports in EmacsKeyBindings there are a lot of Swing imports, so there would probably have to be some porting done |
|
I see! I will look into handling the new GUI framework. Thanks! |
This commit adds a new preference under the Entry editor tab in the preferences. This also maps to the preferences: EDITOR_EMACS_KEYBINDINGS EDITOR_EMACS_KEYBINDINGS_REBIND_CA EDITOR_EMACS_KEYBINDINGS_REBIND_CF [Issue: #9]
The text strings describing the emacs options in preferences were missing, and are now added. [Issue: #9]
Ths commit adds the first step for re-integrating emac keybindings. In this version emacs works globly but dosent have all features yet. [issue: #9]
Emacs key bindings can now be toggled through a preference option in the Entry Editor preference tab [Issue: #9]
There are sub-options deciding whether C-a and C-f should be rebinded as well, which now work as intended [Issue: #9]
Imports were not conforming to the CheckStyle and some localization keys for the Emacs commands were missing [Issue: #9]
This moves all the emacs moves to its own class. [issue: #9]
The old EmacsKeyBindings class is now removed and replaced with a working one. Missing localization keys were also added. [Issue: #9]
If the enabledEmacsKeyBindings checkbox is unchecked, its children will now be disabled to further convey that the children settings are not applied anymore. [Issue: #9 ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back previously-supported keyboard shortcut features.