Add a WTF::String constructor with a base::span<const char>

It simplifies string construction.
This CL has no behavior changes.

Bug: 351564777
Change-Id: Ifdd6a3a9270295a6175653348032167473ac4a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991511
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378632}

Author: tkent-google

third_party/blink/renderer/core/clipboard/clipboard_utilities_test.cc

@@ -41,11 +41,10 @@ TEST(ClipboardUtilitiesTest, URLToImageMarkupEmbeddedNull) {
   const char kTitleWithNull[] = "\0";
   const char kExpectedOutputWithNull[] =
       "<img src=\"http://test.example/%00.png\" alt=\"\0\"/>";
-  EXPECT_EQ(
-      String(base::byte_span_from_cstring(kExpectedOutputWithNull)),
-      URLToImageMarkup(
-          KURL(NullURL(), String(base::byte_span_from_cstring(kURLWithNull))),
-          String(base::byte_span_from_cstring(kTitleWithNull))));
+  EXPECT_EQ(String(base::span_from_cstring(kExpectedOutputWithNull)),
+            URLToImageMarkup(
+                KURL(NullURL(), String(base::span_from_cstring(kURLWithNull))),
+                String(base::span_from_cstring(kTitleWithNull))));
 }
 
 TEST(ClipboardUtilitiesTest, PNGToImageMarkupEmpty) {

third_party/blink/renderer/core/fetch/fetch_data_loader_test.cc

@@ -782,7 +782,7 @@ TEST_F(FetchDataLoaderTest, LoadAsStringWithNullBytes) {
   EXPECT_CALL(*consumer, BeginRead(_)).WillOnce(Return(Result::kDone));
   EXPECT_CALL(*fetch_data_loader_client,
               DidFetchDataLoadedString(
-                  String(base::byte_span_with_nul_from_cstring(kPattern))));
+                  String(base::span_with_nul_from_cstring(kPattern))));
   EXPECT_CALL(checkpoint, Call(3));
   EXPECT_CALL(*consumer, Cancel());
   EXPECT_CALL(checkpoint, Call(4));

third_party/blink/renderer/core/html/parser/html_document_parser_fastpath_test.cc

@@ -315,7 +315,7 @@ TEST(HTMLDocumentParserFastpathTest, NullMappedToReplacementChar) {
   base::HistogramTester histogram_tester;
   // Constructor that takes a base::span is needed because of \0 in string.
   div->setInnerHTML(
-      String(base::byte_span_from_cstring("<div id='x' name='x\0y'></div>")));
+      String(base::span_from_cstring("<div id='x' name='x\0y'></div>")));
   Element* new_div = div->getElementById(AtomicString("x"));
   ASSERT_TRUE(new_div);
   // Null chars are generally mapped to \uFFFD (at least this test should

third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser_test.cc

@@ -19,7 +19,7 @@ namespace multipart_image_resource_parser_test {
 String ToString(const Vector<char>& data) {
   if (data.empty())
     return String("");
-  return String(base::as_byte_span(data));
+  return String(data);
 }
 
 class MockClient final : public GarbageCollected<MockClient>,
@@ -240,9 +240,9 @@ void VariousChunkSizesTest(base::span<const TestChunk> chunks,
     parser->AppendData(data.subspan(chunk.start_position,
                                     chunk.end_position - chunk.start_position));
     EXPECT_EQ(chunk.expected_responses, client->responses_.size());
-    EXPECT_EQ(
-        String(base::as_byte_span(chunk.expected_data)),
-        client->data_.size() > 0 ? ToString(client->data_.back()) : String(""));
+    EXPECT_EQ(String(chunk.expected_data), client->data_.size() > 0
+                                               ? ToString(client->data_.back())
+                                               : String(""));
   }
   // Check final state
   parser->Finish();

third_party/blink/renderer/platform/exported/web_string.cc

@@ -109,7 +109,7 @@ std::string WebString::Latin1() const {
 }
 
 WebString WebString::FromLatin1(std::string_view s) {
-  return String(base::as_bytes(base::span(s)));
+  return String(s);
 }
 
 std::string WebString::Ascii() const {

third_party/blink/renderer/platform/peerconnection/rtc_ice_candidate_platform.cc

@@ -85,7 +85,7 @@ void RTCIceCandidatePlatform::PopulateFields(bool use_username_from_candidate) {
   auto type = c.type_name();
   DCHECK(type == "host" || type == "srflx" || type == "prflx" ||
          type == "relay");
-  type_ = String(base::as_byte_span(type));
+  type_ = String(type);
   if (!c.tcptype().empty()) {
     tcp_type_ = String::FromUTF8(c.tcptype());
   }

third_party/blink/renderer/platform/text/unicode_utilities_test.cc

@@ -150,7 +150,7 @@ TEST(UnicodeUtilitiesTest, FoldQuoteMarkOrSoftHyphenTest) {
 
   FoldQuoteMarksAndSoftHyphens(string_to_fold);
 
-  const String folded_string(base::byte_span_from_cstring("\"\"\"\'\'\'\0"));
+  const String folded_string(base::span_from_cstring("\"\"\"\'\'\'\0"));
   ASSERT_EQ(std::size(kCharactersToFold), folded_string.length());
   EXPECT_EQ(string_to_fold, folded_string);
 

third_party/blink/renderer/platform/wtf/text/wtf_string.cc

@@ -242,8 +242,7 @@ String String::Format(const char* format, ...) {
     va_end(args);
   }
 
-  return String(base::as_bytes(
-      base::span(buffer).first(base::checked_cast<size_t>(length))));
+  return String(base::span(buffer).first(base::checked_cast<size_t>(length)));
 }
 
 String String::EncodeForDebugging() const {

third_party/blink/renderer/platform/wtf/text/wtf_string.h

@@ -84,6 +84,8 @@ class WTF_EXPORT String {
 
   // Construct a string with latin1 data.
   explicit String(base::span<const LChar> latin1_data);
+  explicit String(base::span<const char> latin1_data)
+      : String(base::as_bytes(latin1_data)) {}
   String(const char* characters, unsigned length);
   explicit String(const std::string& s) : String(base::as_byte_span(s)) {}