Skip to content

Commit e5faf77

Browse files
committed
Change tests to check for not-null before checking equality of strings
1 parent ca415bd commit e5faf77

File tree

2 files changed

+23
-10
lines changed

2 files changed

+23
-10
lines changed

src/tests/java/ProcessorTests.java

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,12 @@ public void testProcessValue() {
1919
assertEquals("", JSONProcessor.processValue("\"\""));
2020

2121
// Test numbers
22-
assertEquals(42.0, (double) JSONProcessor.processValue("42"), 0.001);
23-
assertEquals(-3.14, (double) JSONProcessor.processValue("-3.14"), 0.001);
24-
assertEquals(1.23e-4, (double) JSONProcessor.processValue("1.23e-4"), 0.00001);
22+
Number num = (Number)JSONProcessor.processValue("42");
23+
assertEquals(42, num.intValue());
24+
num = (Number)JSONProcessor.processValue("-3.14");
25+
assertEquals(-3.14, num.doubleValue(), 0.001);
26+
num = (Number)JSONProcessor.processValue("1.23e-4");
27+
assertEquals(1.23e-4, num.doubleValue(), 0.00001);
2528

2629
// Test booleans
2730
assertEquals(Boolean.TRUE, JSONProcessor.processValue("true"));
@@ -61,12 +64,16 @@ public void testProcessString() {
6164
@Test
6265
public void testProcessNumber() {
6366
// Test integers
64-
assertEquals(42.0, (double) JSONProcessor.processNumber("42"), 0.001);
65-
assertEquals(-42.0, (double) JSONProcessor.processNumber("-42"), 0.001);
67+
Number num = JSONProcessor.processNumber("42");
68+
assertEquals(42, num.intValue());
69+
num = JSONProcessor.processNumber("-42");
70+
assertEquals(-42, num.intValue());
6671

6772
// Test decimals
68-
assertEquals(3.14, (double) JSONProcessor.processNumber("3.14"), 0.001);
69-
assertEquals(-3.14, (double) JSONProcessor.processNumber("-3.14"), 0.001);
73+
num = JSONProcessor.processNumber("3.14");
74+
assertEquals(3.14, num.doubleValue(), 0.001);
75+
num = JSONProcessor.processNumber("-3.14");
76+
assertEquals(-3.14, num.doubleValue(), 0.001);
7077

7178
// Test scientific notation
7279
assertEquals(1.23e-4, (double) JSONProcessor.processNumber("1.23e-4"), 0.00001);
@@ -88,7 +95,8 @@ public void testProcessArray() {
8895
// Test simple array
8996
List<Object> numbers = JSONProcessor.processArray("[1,2,3]");
9097
assertEquals(3, numbers.size());
91-
assertEquals(1.0, numbers.get(0));
98+
Number num = (Number)numbers.get(0);
99+
assertEquals(1, num.intValue());
92100

93101
// Test mixed array
94102
List<Object> mixed = JSONProcessor.processArray("[1,\"two\",true]");

src/tests/java/Tests.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import static org.junit.Assert.assertEquals;
2+
import static org.junit.Assert.assertNotNull;
23

34
import java.nio.file.Path;
45
import java.util.List;
@@ -13,8 +14,12 @@ public class Tests {
1314
@Test
1415
public void testNumbers() {
1516
String expected = String.join("\n", FileOperations.readFile(Path.of("src\\tests\\java\\data\\test1\\expected1.out")));
16-
String actual = JSONProcessor.processJson(Path.of("src\\tests\\java\\data\\test1\\test1.json")).toString();
17-
assertEquals(expected, actual);
17+
assertNotNull("Expected file content should not be null", expected);
18+
19+
String result = JSONProcessor.processJson(Path.of("src\\tests\\java\\data\\test1\\test1.json")).toString();
20+
assertNotNull("Processed JSON should not be null", result);
21+
22+
assertEquals(expected, result);
1823
}
1924

2025
@Test

0 commit comments

Comments
 (0)