Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA Review: User Authentication #2

Closed
14 of 15 tasks
steveninouye opened this issue Dec 13, 2018 · 1 comment
Closed
14 of 15 tasks

PA Review: User Authentication #2

steveninouye opened this issue Dec 13, 2018 · 1 comment
Assignees

Comments

@steveninouye
Copy link
Owner

steveninouye commented Dec 13, 2018

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components and Containers
  • Styling
  • Smooth, bug-free navigation
  • User can log in
  • User can log out
  • Feedback is displayed to the user (login/sign up errors)
  • Errors are cleared when user navigates to a different page
  • User remains logged in when refreshing the page
  • Links work appropriately
  • User is unable to navigate to sign in/sign up form after being logged in
  • User's password is a minimum of 6 characters
  • Username has to be unique
  • User have a option of a demo login
@andywynkoop
Copy link
Collaborator

andywynkoop commented Dec 13, 2018

  • This is looking great so far!
  • The favicon is a nice touch
  • icons for facebook and google buttons should be the same size
  • For those right-side buttons: no border radius, and about 10px more padding - colors, styling and transitions should match ebay's exactly
  • Remove colons from placeholder values in session inputs
  • hr should be a little lighter grey
  • nav bar should span the entire screen, not just inner container
  • but the create account link should be somewhere in this form (maybe in the top sentence along with the demo account)
  • going to a random route, /fsafas, should redirect to / or render a 404 page
  • all nav links should be styled with cursor: pointer (even if they don't do anything yet)
  • same for the placeholder category links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants