Merge pull request tractionguest#20 from tractionguest/bugfix/member-id-to-int

[SST-15759] convert member list ids to integers

Author: myang0

app/controllers/scim_rails/scim_groups_controller.rb

@@ -164,9 +164,11 @@ def put_error_check
     end
 
     def add_members(group, member_ids)
+      member_ids = member_ids.map{ |id| id.to_i }
+
       new_member_ids = member_ids - group.public_send(ScimRails.config.scim_group_member_scope).pluck(:id)
       new_members = @company.public_send(ScimRails.config.scim_users_scope).find(new_member_ids)
-      
+
       group.public_send(ScimRails.config.scim_group_member_scope) << new_members if new_members.present?
     end
 

spec/controllers/scim_rails/scim_groups_controller_spec.rb

@@ -686,6 +686,34 @@
                   expect(response.status).to eq(404)
                 end
               end
+
+              context "with repeated member additions" do
+                let(:patch_value) { [ { value: new_user.id } ] }
+
+                let(:alt_patch_value) { [ { value: new_user.id.to_s } ] }
+                let(:alt_params) do
+                  {
+                    id: patch_id,
+                    Operations: [
+                      {
+                        op: patch_operation,
+                        path: patch_path,
+                        value: alt_patch_value
+                      }
+                    ]
+                  }
+                end
+
+                let(:alt_patch) { patch :patch_update, params: alt_params, as: :json }
+
+                it "only adds member to group once" do
+                  expect(response.status).to eq(200)
+                  expect(updated_user_list.length).to eq(user_list_length + 1)
+                  expect(updated_user_ids).to include(new_user.id)
+
+                  expect{ alt_patch }.to_not change{ updated_user_list.length }
+                end
+              end
             end
 
             context "when path not set to 'members'" do