ignore default scopes on user model

Author: Scott Hagan

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    scim_rails (0.3.0)
+    scim_rails (0.3.1)
       jwt (>= 1.5, < 3.0)
       rails (~> 5.0)
 
@@ -72,7 +72,7 @@ GEM
       concurrent-ruby (~> 1.0)
     interception (0.5)
     json (2.4.0)
-    jwt (2.2.1)
+    jwt (2.2.2)
     loofah (2.6.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
@@ -81,11 +81,14 @@ GEM
     marcel (0.3.3)
       mimemagic (~> 0.3.2)
     method_source (1.0.0)
+    mime-types (3.2.2)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2021.0225)
     mimemagic (0.3.5)
-    mini_mime (1.0.2)
+    mini_mime (1.0.3)
     mini_portile2 (2.4.0)
     minitest (5.14.1)
-    nio4r (2.5.2)
+    nio4r (2.5.7)
     nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
     pry (0.13.1)
@@ -148,7 +151,7 @@ GEM
     sprockets (4.0.2)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
-    sprockets-rails (3.2.1)
+    sprockets-rails (3.2.2)
       actionpack (>= 4.0)
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
@@ -170,6 +173,9 @@ DEPENDENCIES
   byebug
   factory_bot_rails
   faker
+  mime-types (~> 3.2.2)
+  mime-types-data
+  mimemagic (~> 0.3.0)
   pry
   pry-rescue
   rake (~> 13.0)

app/controllers/scim_rails/scim_users_controller.rb

@@ -40,12 +40,14 @@ def create
       else
         username_key = ScimRails.config.queryable_user_attributes[:userName]
 
-        find_by_username = Hash.new
+        find_by_params = Hash.new
 
-        find_by_username[username_key] = user_params[username_key]
-        user = @company
-          .public_send(ScimRails.config.scim_users_scope)
-          .find_or_create_by(find_by_username)
+        find_by_params[username_key] = user_params[username_key]
+        find_by_params[ScimRails.config.basic_auth_model.to_s.underscore] = @company
+
+        user = ScimRails.config.scim_users_model
+          .unscoped # Specific to our use case and should be changed back after we remove the default_scope from our "User" model
+          .find_or_initialize_by(find_by_params)
         user.update!(user_params)
       end
       update_status(user) unless params[:active].nil?

lib/scim_rails/version.rb

@@ -1,3 +1,3 @@
 module ScimRails
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

scim_rails.gemspec

@@ -33,4 +33,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "sqlite3", "~> 1.3.6"
   s.add_development_dependency "simplecov", "< 0.18.0"
   s.add_development_dependency "simplecov_json_formatter"
+  s.add_development_dependency 'mime-types', '~> 3.2.2'
+  s.add_development_dependency 'mime-types-data'
+  s.add_development_dependency 'mimemagic', '~> 0.3.0'
 end

spec/controllers/scim_rails/scim_users_controller_spec.rb

@@ -347,6 +347,24 @@
         expect(company.users.count).to eq 1
       end
 
+      it 'returns 201 if the user has a default_scope attribute' do
+        create(:user, email: "new@example.com", company: company, scoped_attribute: false)
+        post :create, params: {
+          name: {
+            givenName: "Not New",
+            familyName: "User"
+          },
+          emails: [
+            {
+              value: "new@example.com"
+            }
+          ]
+        }
+        expect(response.status).to eq 201
+        expect(User.unscoped.where(company: company).count).to eq 1
+        expect(User.unscoped.where(company: company).first.first_name).to eq "Not New"
+      end
+
       it "creates and archives inactive user" do
         post :create, params: {
           id: 1,

spec/dummy/app/models/user.rb

@@ -4,6 +4,8 @@ class User < ApplicationRecord
   has_many :groups_users
   has_many :groups, through: :groups_users
 
+  default_scope { where(scoped_attribute: true) }
+
   validates \
     :first_name,
     :last_name,

spec/dummy/db/migrate/20210331202326_add_scoped_attribute.rb

@@ -0,0 +1,5 @@
+class AddScopedAttribute < ActiveRecord::Migration[5.2]
+  def change
+    add_column :users, :scoped_attribute, :boolean, default: true
+  end
+end

spec/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_04_08_164220) do
+ActiveRecord::Schema.define(version: 2021_03_31_202326) do
 
   create_table "companies", force: :cascade do |t|
     t.string "name", null: false
@@ -50,6 +50,7 @@
     t.datetime "archived_at"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
+    t.boolean "scoped_attribute", default: true
   end
 
 end

spec/factories/user.rb

@@ -7,6 +7,7 @@
     sequence(:email) { |n| "#{n}@example.com" }
 
     test_attribute { Faker::Games::Pokemon.name }
+    scoped_attribute { true }
     alternate_email { Faker::Internet.email }
   end
 end

spec/spec_helper.rb

@@ -21,4 +21,6 @@
  config.use_transactional_fixtures = true
  config.infer_base_class_for_anonymous_controllers = false
  config.order = "random"
+ config.filter_run :focus
+ config.run_all_when_everything_filtered = true
 end