Add proper spec for SCIM user schema

- Fix missing fields.
- It is a pain to duplicate the schema fields in the spec; however:
  - It makes sure that we don't miss any

Author: Andrew Burns

app/services/parameter_service.rb

@@ -13,10 +13,27 @@ module ParameterService
   # https://datatracker.ietf.org/doc/html/rfc7643#section-4
   SCIM_CORE_USER_SCHEMA = {
     "id" => :value,
-    "department" => :value,
     "userName" => :value,
+    "externalId" => :value,
+    "active" => :value,
+    "addresses" => [],
+    "costCenter" => :value,
+    "department" => :value,
     "displayName" => :value,
-    "nickName" => :value,
+    "division" => :value,
+    "emails" => [],
+    "employeeNumber" => :value,
+    "entitlements" => [],
+    "groups" => [],
+    "ims" => [],
+    "locale" => :value,
+    "meta" => {
+      "resourceType" => :value,
+      "created" => :value,
+      "lastModified" => :value,
+      "location" => :value,
+      "version" => :value,
+    },
     "name" => {
       "formatted" => :value,
       "familyName" => :value,
@@ -25,28 +42,17 @@ module ParameterService
       "honorificPrefix" => :value,
       "honorificSuffix" => :value,
     },
-    "profileUrl" => :value,
-    "title" => :value,
-    "userType" => :value,
-    "preferredLanguage" => :value,
-    "locale" => :value,
-    "timezone" => :value,
-    "active" => :value,
+    "nickName" => :value,
+    "organization" => :value,
     "password" => :value,
-    "emails" => [],
     "phoneNumbers" => [],
-    "ims" => :value,
-    "photos" => :value,
-    "addresses" => {
-      "formatted" => :value,
-      "streetAddress" => :value,
-      "locality" => :value,
-      "region" => :value,
-      "postalCode" => :value,
-      "country" => :value,
-    },
-    "entitlements" => [],
+    "photos" => [],
+    "preferredLanguage" => :value,
+    "profileUrl" => :value,
     "roles" => [],
+    "timezone" => :value,
+    "title" => :value,
+    "userType" => :value,
     "x509Certificates" => [],
   }
 

spec/services/parameter_service_spec.rb

@@ -1,6 +1,86 @@
 require "spec_helper"
 
 RSpec.describe ParameterService, type: :service do
+  describe "SCIM_CORE_USER_SCHEMA.contains?" do
+    let(:schema) { ParameterService::SCIM_CORE_USER_SCHEMA }
+
+    # Singular Simple Value Attributes
+    %w(
+       id
+       externalId
+       userName
+       displayName
+       nickName
+       profileUrl
+       title
+       userType
+       preferredLanguage
+       locale
+       timezone
+       active
+       password
+       employeeNumber
+       costCenter
+       organization
+       division
+       department
+    ).each do |attr|
+      it attr do
+        expect(schema).to have_key(attr), "Expected schema to have simple attribute #{attr}"
+        expect(schema[attr]).to be_kind_of(Symbol), "Expected schema attribute #{attr} to be a simple value!"
+      end
+    end
+
+    # Complex Types
+    {
+      meta: %w(
+        resourceType
+        created
+        lastModified
+        location
+        version
+      ),
+      name: %w(
+        formatted
+        familyName
+        givenName
+        middleName
+        honorificPrefix
+        honorificSuffix
+      ),
+    }.stringify_keys.each do |attr, sub_attrs|
+      it "#{attr} (and #{sub_attrs.length} sub-fields)" do
+        sub_schema = schema[attr]
+
+        expect(schema).to have_key(attr), "Expected schema to have root key #{attr}"
+        expect(schema[attr]).to be_kind_of(Hash), "Expected schema attribute #{attr} to be a Hash!"
+
+        sub_attrs.each do |sub_attr|
+          expect(sub_schema).to have_key(sub_attr), "Expected schema.#{attr} to have key #{sub_attr}"
+        end
+      end
+    end
+
+    # Muti-Valued Array Attributes
+    %w(
+        addresses
+        emails
+        phoneNumbers
+        ims
+        photos
+        groups
+        entitlements
+        roles
+        x509Certificates
+    ).each do |attr|
+      it "#{attr} (array)" do
+        expect(schema).to have_key(attr), "Expected schema to have root key #{attr}"
+        expect(schema[attr]).to be_kind_of(Array), "Expected schema attribute #{attr} to be an array!"
+      end
+    end
+
+  end
+
   describe ".invalid_parameters" do
     let(:schema) { ParameterService::SCIM_CORE_USER_SCHEMA }
     let(:good_params) do
@@ -61,6 +141,41 @@
       end
     end
 
+    context "valid" do
+      context "core schema - " do
+        ParameterService::SCIM_CORE_USER_SCHEMA.each do |key, schema_metadata|
+           data =
+             case schema_metadata.class.name
+             when Hash.name
+               d = schema_metadata.dup
+               d.keys.each do |k|
+                 d[k] = Faker::Lorem.sentence
+               end
+               d
+             when Array.name
+               [Faker::Lorem.sentence]
+             when Symbol.name
+               Faker::Lorem.sentence
+             else
+               :fail
+             end
+
+           if data == :fail
+             it key.to_s do
+               fail "Unknown data type in schema :#{key} => #{schema_metadata.class}"
+             end
+           else
+             it key.to_s do
+               params = good_params.merge(key => data)
+
+               result = subject.invalid_parameters(schema, params)
+               expect(result).to be_empty
+             end
+          end
+        end
+      end
+    end
+
     context "invalid" do
       context "data type" do
         it "schema=Hash, param=String" do