ADD: Additional Client Options #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more client options
added more option, including slasher for Lighthouse as well as removing unused pruning option for Besu
This was
linked to
issues
Sep 30, 2024
NeoPlays
requested changes
Oct 2, 2024
| this.item.yaml = this.item.yaml.replace(new RegExp(/\n^.*\/opt\/app\/slasher*$/gm), ""); | ||
| } else if (this.item.yaml.includes("--slasher") && !this.item.yaml.includes("/opt/app/slasher")) { | ||
| this.item.yaml = this.item.yaml.replace("--slasher","--slasher\n - --slasher-dir=/opt/app/slasher"); | ||
| this.item.yaml = this.item.yaml.replace("volumes:" ,"volumes:\n - /opt/stereum/lighthouse-" + this.item.config.serviceID +"/slasher:/opt/app/slasher") |
There was a problem hiding this comment.
You may run into some issues here.
The problem is, that ansible sometimes messes with the format of the config which may result in something like this:
volumes:
- someVolume
- someVolume
your solution would end up as:
volumes:
- someVolume
- someVolume
- someVolume
Not only that, another problem ist, that users might use another path than the default /opt/stereum for this service.
fixed formating and custom install volume problem
NeoPlays
previously approved these changes
Oct 3, 2024
NeoPlays
approved these changes
Oct 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more client options