Some useless todos fixed

Author: stepancheg

httpbis/src/client/conn.rs

@@ -124,15 +124,9 @@ pub(crate) enum ClientToWriteMessage {
 impl ErrorAwareDrop for ClientToWriteMessage {
     fn drop_with_error(self, error: crate::Error) {
         match self {
-            ClientToWriteMessage::Start(start) => {
-                start.start.stream_handler.error(error);
-            }
-            ClientToWriteMessage::WaitForHandshake(wait) => {
-                let _ = wait.send(Err(error));
-            }
-            ClientToWriteMessage::Common(_) => {
-                // TODO: error
-            }
+            ClientToWriteMessage::Start(start) => start.start.stream_handler.error(error),
+            ClientToWriteMessage::WaitForHandshake(wait) => drop(wait.send(Err(error))),
+            ClientToWriteMessage::Common(common) => common.drop_with_error(error),
         }
     }
 }

httpbis/src/common/conn_write.rs

@@ -29,9 +29,11 @@ use crate::solicit::frame::RstStreamFrame;
 use crate::solicit::frame::SettingsFrame;
 use crate::solicit::stream_id::StreamId;
 use crate::DataOrTrailers;
+use crate::Error;
 use crate::ErrorCode;
 use crate::Headers;
 
+use crate::death::channel::ErrorAwareDrop;
 use crate::death::error_holder::ConnDiedType;
 use crate::death::oneshot::DeathAwareOneshotSender;
 use crate::solicit_async::TryStreamBox;
@@ -293,6 +295,19 @@ pub(crate) enum CommonToWriteMessage {
     DumpState(DeathAwareOneshotSender<ConnStateSnapshot, ConnDiedType>),
 }
 
+impl ErrorAwareDrop for CommonToWriteMessage {
+    fn drop_with_error(self, error: Error) {
+        let _ = error;
+        match self {
+            CommonToWriteMessage::IncreaseInWindow(_, _) => {}
+            CommonToWriteMessage::StreamEnqueue(_, _) => {}
+            CommonToWriteMessage::StreamEnd(_, _) => {}
+            CommonToWriteMessage::Pull(_, _, _) => {}
+            CommonToWriteMessage::DumpState(_) => {}
+        }
+    }
+}
+
 impl fmt::Debug for CommonToWriteMessage {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.debug_tuple("CommonToWriteMessage").field(&"...").finish()