Skip to content

Commit dfbe20c

Browse files
authored
Merge pull request #317 from AndreasReitberger/master
Fixed `LiteDB` security issue
2 parents 9a96756 + 3db88f6 commit dfbe20c

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

src/Firebase/Firebase.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@
3030
</PropertyGroup>
3131

3232
<ItemGroup>
33-
<PackageReference Include="LiteDB" Version="4.1.4" />
34-
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
35-
<PackageReference Include="System.Reactive" Version="4.0.0" />
36-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-19367-01" PrivateAssets="All" />
33+
<PackageReference Include="LiteDB" Version="5.0.17" />
34+
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
35+
<PackageReference Include="System.Reactive" Version="6.0.0" />
36+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
3737
</ItemGroup>
3838

3939
</Project>

src/Firebase/Offline/ConcurrentOfflineDatabase.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,9 @@ public void Add(KeyValuePair<string, OfflineEntry> item)
118118
public void Clear()
119119
{
120120
this.ccache.Clear();
121-
this.db.Delete<OfflineEntry>(Query.All());
121+
// Only works for v4, v5 see https://github.com/mbdavid/LiteDB/issues/1478
122+
//this.db.Delete<OfflineEntry>(Query.All());
123+
this.db.DeleteMany<OfflineEntry>(_ => true);
122124
}
123125

124126
/// <summary>

src/Firebase/Offline/OfflineDatabase.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,9 @@ public void Add(KeyValuePair<string, OfflineEntry> item)
113113
public void Clear()
114114
{
115115
this.cache.Clear();
116-
this.db.Delete<OfflineEntry>(Query.All());
116+
// Only works for v4, v5 see https://github.com/mbdavid/LiteDB/issues/1478
117+
//this.db.Delete<OfflineEntry>(Query.All());
118+
this.db.DeleteMany<OfflineEntry>(_ => true);
117119
}
118120

119121
/// <summary>

0 commit comments

Comments
 (0)