Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bls12-381 cost types #211

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add bls12-381 cost types #211

merged 1 commit into from
Sep 3, 2024

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented Aug 27, 2024

No description provided.

@anupsdf
Copy link

anupsdf commented Sep 3, 2024

Instead of separate G1 and G2 cost types should we have just one? Then we can call something like Bls12381GroupAdd, Bls12381GroupMul etc.

Looking at the equation seems like Fq2 is constant,

G1 curve equation: y^2 = x^3 + 4
G2 curve equation: y^2 = x^3 + Fq2(4, 4)

@jayz22
Copy link
Contributor Author

jayz22 commented Sep 3, 2024

Instead of separate G1 and G2 cost types should we have just one? Then we can call something like Bls12381GroupAdd, Bls12381GroupMul etc.

Looking at the equation seems like Fq2 is constant,

G1 curve equation: y^2 = x^3 + 4
G2 curve equation: y^2 = x^3 + Fq2(4, 4)

No if the groups are different, the costs are different.

@anupsdf anupsdf merged commit a7d5951 into stellar:curr Sep 3, 2024
1 check passed
jayz22 added a commit to jayz22/stellar-xdr that referenced this pull request Sep 3, 2024
anupsdf pushed a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants